On Wed, Jul 14, 2021 at 8:47 AM Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> wrote: > > Proc socket stats use sk_prot->inuse_idx value to record inuse sock stats. > We currently do not set this correctly from sockmap side. The result is > reading sock stats '/proc/net/sockstat' gives incorrect values. The > socket counter is incremented correctly, but because we don't set the > counter correctly when we replace sk_prot we may omit the decrement. > > To get the correct inuse_idx value move the core_initcall that initializes > the udp proto handlers to late_initcall. This way it is initialized after > UDP has the chance to assign the inuse_idx value from the register protocol > handler. > > Fixes: edc6741cc660 ("bpf: Add sockmap hooks for UDP sockets") > Acked-by: John Fastabend <john.fastabend@xxxxxxxxx> > Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> Reviewed-by: Cong Wang <cong.wang@xxxxxxxxxxxxx> Thanks for the update!