Hi Ingo, Here is a series of patches to cleanup the kprobes code. I tried to fix error message issues, comments, checkpatch.pl issues and so on. Some of those are what you suggested and pointed in the x86 stacktrace series. https://lore.kernel.org/bpf/YOK39GTuueIDeaJL@xxxxxxxxx/ I decided to split this seires from the x86 stacktrace fix series because there still be some on going discussions on that thread. The stacktrace fix series will be rebased on this series (and I've almost done, except for some discussion items). Since this is a cleanup series, this does not change any functionality (of course some error messages, warnings, lock assertions are chaneged) but the coding styles are improved. I will continue this cleanup activities for each architecture port, and rethink the internal coding design and interfaces too. Thank you, --- Masami Hiramatsu (6): kprobes: treewide: Cleanup the error messages for kprobes kprobes: Fix coding style issues kprobes: Use IS_ENABLED() instead of kprobes_built_in() kprobes: Add assertions for required lock kprobes: treewide: Use 'kprobe_opcode_t *' for the code address in get_optimized_kprobe() kprobes: Use bool type for functions which returns boolean value arch/arm/probes/kprobes/core.c | 4 arch/arm/probes/kprobes/opt-arm.c | 7 - arch/arm64/kernel/probes/kprobes.c | 5 - arch/csky/kernel/probes/kprobes.c | 10 + arch/mips/kernel/kprobes.c | 11 + arch/powerpc/kernel/optprobes.c | 6 - arch/riscv/kernel/probes/kprobes.c | 11 + arch/s390/kernel/kprobes.c | 4 arch/x86/kernel/kprobes/opt.c | 6 - include/linux/kprobes.h | 64 +++---- kernel/kprobes.c | 315 +++++++++++++++++++----------------- 11 files changed, 226 insertions(+), 217 deletions(-) -- Masami Hiramatsu (Linaro) <mhiramat@xxxxxxxxxx>
