On Thu, Jun 03, 2021 at 05:20:58AM IST, Alexei Starovoitov wrote:
> On Thu, Jun 03, 2021 at 03:15:13AM +0530, Kumar Kartikeya Dwivedi wrote:
> >
> > > The problem is that your patch set was marked as spam by Google, so I
> > > suspect a bunch of folks haven't gotten it. I suggest re-sending it
> > > again but trimming down the CC list, leaving only bpf@vger,
> > > netdev@vger, and BPF maintainers CC'ed directly.
> > >
> >
> > Thanks for the heads up, I'll resend tomorrow.
>
> fyi I see this thread in my inbox, but, sadly, not the patches.
> So guessing based on cover letter and hoping that the following is true:
> link_fd is returned by BPF_LINK_CREATE command.
> If anything is missing in struct link_create the patches are adding it there.
> target_ifindex, flags are reused. attach_type indicates ingress vs egress.
Everything is true except the attach_type part. I don't hook directly into
sch_handle_{ingress,egress}. It's a normal TC filter, and if one wants to hook
into ingress, egress, they attach it to clsact qdisc. The lifetime however is
decided by the link fd.
The new version is here:
https://lore.kernel.org/bpf/20210604063116.234316-1-memxor@xxxxxxxxx
--
Kartikeya
