> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Maciej Fijalkowski > Sent: Thursday, May 20, 2021 12:05 PM > To: intel-wired-lan@xxxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; Jamal Hadi Salim <jhs@xxxxxxxxxxxx>; > bjorn@xxxxxxxxxx; kuba@xxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; > davem@xxxxxxxxxxxxx; Karlsson, Magnus <magnus.karlsson@xxxxxxxxx> > Subject: [Intel-wired-lan] [PATCH v2 intel-net 1/2] ice: add ndo_bpf callback > for safe mode netdev ops > > ice driver requires a programmable pipeline firmware package in order to > have a support for advanced features. Otherwise, driver falls back to so > called 'safe mode'. For that mode, ndo_bpf callback is not exposed and when > user tries to load XDP program, the following happens: > > $ sudo ./xdp1 enp179s0f1 > libbpf: Kernel error message: Underlying driver does not support XDP in > native mode link set xdp fd failed > > which is sort of confusing, as there is a native XDP support, but not in the > current mode. Improve the user experience by providing the specific > ndo_bpf callback dedicated for safe mode which will make use of extack to > explicitly let the user know that the DDP package is missing and that's the > reason that the XDP can't be loaded onto interface currently. > > Cc: Jamal Hadi Salim <jhs@xxxxxxxxxxxx> > Fixes: efc2214b6047 ("ice: Add support for XDP") > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Tested-by: Kiran Bhandare <kiranx.bhandare@xxxxxxxxx> A Contingent Worker at Intel