Re: [PATCH bpf-next 03/11] bpfilter: Add IO functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 18, 2021 at 11:06 PM Dmitrii Banshchikov <me@xxxxxxxxxxxxx> wrote:
>
> Introduce IO functions for:
> 1) reading and writing data from a descriptor: read_exact(), write_exact(),
> 2) reading and writing memory of other processes: pvm_read(), pvm_write().
>
> read_exact() and write_exact() are wrappers over read(2)/write(2) with
> correct handling of partial read/write. These functions are intended to
> be used for communication over pipe with the kernel part of bpfilter.
>
> pvm_read() and pvm_write() are wrappers over
> process_vm_readv(2)/process_vm_writev(2) with an interface that uses a
> single buffer instead of vectored form. These functions are intended to
> be used for readining/writing memory buffers supplied to iptables ABI
> setsockopt(2) from other processes.
>
> Signed-off-by: Dmitrii Banshchikov <me@xxxxxxxxxxxxx>

The code looks correct, so

Acked-by: Song Liu <songliubraving@xxxxxx>

However, I am not sure whether we really want these wrapper functions.

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux