Re: [PATCH v4 bpf-next 20/22] selftests/bpf: Convert atomics test to light skeleton.

[Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>]

On Fri, May 7, 2021 at 8:49 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> From: Alexei Starovoitov <ast@xxxxxxxxxx>
>
> Convert prog_tests/atomics.c to lskel.h
>
> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> ---

Less CHECK()s, yay.

Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

>  tools/testing/selftests/bpf/Makefile          |  2 +-
>  .../selftests/bpf/prog_tests/atomics.c        | 73 ++++++++++---------
>  2 files changed, 38 insertions(+), 37 deletions(-)
>

[...]

> @@ -32,21 +32,22 @@ static void test_add(struct atomics *skel)
>
>         ASSERT_EQ(skel->data->add_noreturn_value, 3, "add_noreturn_value");
>
> +

why extra empty line?

>  cleanup:
> -       bpf_link__destroy(link);
> +       close(link_fd);
>  }
>

[...]