On Fri, Apr 30, 2021 at 9:56 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Thu, Apr 29, 2021 at 8:32 AM Jussi Maki <joamaki@xxxxxxxxx> wrote: > > > > Ports test_tc_redirect.sh to the test_progs framework and removes the > > old test. This makes it more in line with rest of the tests and makes > > it possible to run this test with vmtest.sh and under the bpf CI. > > > > Signed-off-by: Jussi Maki <joamaki@xxxxxxxxx> > > --- > > Aren't there any Makefile changes that need to be done as well, given > you are removing "old style" test script? Nope, it isn't mentioned anywhere. I'll send a v2 that addresses your comments, e.g. switching to ASSERT_xxx() and rewroting the sysctl stuff to handle errors and restore original values so it won't affect other tests.