On Wed, Apr 14, 2021 at 05:16:01PM -0700, Andrii Nakryiko wrote: > On Wed, Apr 14, 2021 at 6:18 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > > On Tue, Apr 13, 2021 at 01:45:39PM -0700, Nick Desaulniers wrote: > > > > SNIP > > > > > > > > > > > > > > So I'm not sure precisely what's going on here. I probably have to go > > > > > > digging around to understand tools/build/feature/ anyways. With your > > > > > > v3 applied, I consistently see: > > > > > > No zlib found > > > > > > and yet, I certainly do have zlib on my host. > > > > > > https://stackoverflow.com/a/54558861 > > > > > > > > > > Jiri, any tips on how to debug feature detection in > > > > > tools/build/feature/Makefile? > > > > > > > > for quick check, there's output file for each test, like: > > > > > > > > [jolsa@krava feature]$ ls -l *.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-all.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 182 Apr 9 15:52 test-bionic.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-cplus-demangle.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 145 Apr 9 15:52 test-jvmti.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-libbabeltrace.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-libbpf.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-libdebuginfod.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 193 Apr 9 15:52 test-libunwind-aarch64.make.output > > > > -rw-rw-r--. 1 jolsa jolsa 177 Apr 9 15:52 test-libunwind-x86.make.output > > > > [jolsa@krava feature]$ cat test-libunwind-aarch64.make.output > > > > test-libunwind-aarch64.c:2:10: fatal error: libunwind-aarch64.h: No such file or directory > > > > 2 | #include <libunwind-aarch64.h> > > > > | ^~~~~~~~~~~~~~~~~~~~~ > > > > compilation terminated. > > > > [jolsa@krava feature]$ cat test-libunwind-x86.make.output > > > > test-libunwind-x86.c:2:10: fatal error: libunwind-x86.h: No such file or directory > > > > 2 | #include <libunwind-x86.h> > > > > | ^~~~~~~~~~~~~~~~~ > > > > > > > > zlib should be done by: > > > > [jolsa@krava feature]$ make test-zlib.bin > > > > gcc -MD -Wall -Werror -o test-zlib.bin test-zlib.c > test-zlib.make.output 2>&1 -lz > > > > > > > > > > > > I can try to recreate, how do you build? > > > > > > See note above, I'm similarly running precisely: > > > $ make LLVM=1 LLVM_IAS=1 -j72 defconfig > > > $ make LLVM=1 LLVM_IAS=1 -j72 clean > > > $ make LLVM=1 LLVM_IAS=1 -j72 -C tools/testing/selftests/bpf > > > > for some reason I'm stuck with this error on latest bpf-next/master > > did you build vmlinux image before building selftests? those enums > should come through vmlinux.h from up-to-date vmlinux it was there.. but I found the clang/lld I compiled can't link properly, which is probably unrelated to the error below, but I need to solve it first ;-) jirka > > > > > $ make LLVM=1 LLVM_IAS=1 -C tools/testing/selftests/bpf > > > > make[1]: Nothing to be done for 'docs'. > > CLNG-BPF [test_maps] test_lwt_ip_encap.o > > CLNG-BPF [test_maps] test_tc_edt.o > > CLNG-BPF [test_maps] local_storage.o > > progs/local_storage.c:41:15: error: use of undeclared identifier 'BPF_MAP_TYPE_TASK_STORAGE'; did you mean 'BPF_MAP_TYPE_SK_STORAGE'? > > __uint(type, BPF_MAP_TYPE_TASK_STORAGE); > > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > BPF_MAP_TYPE_SK_STORAGE > > /home/jolsa/linux/tools/testing/selftests/bpf/tools/include/bpf/bpf_helpers.h:13:39: note: expanded from macro '__uint' > > #define __uint(name, val) int (*name)[val] > > ^ > > /home/jolsa/linux/tools/testing/selftests/bpf/tools/include/vmlinux.h:10317:2: note: 'BPF_MAP_TYPE_SK_STORAGE' declared here > > BPF_MAP_TYPE_SK_STORAGE = 24, > > ^ > > 1 error generated. > > make: *** [Makefile:448: /home/jolsa/linux/tools/testing/selftests/bpf/local_storage.o] Error 1 > > make: Leaving directory '/home/jolsa/linux/tools/testing/selftests/bpf' > > > > > > jirka > > >
