Hey Geert! :) On Wed, Apr 14, 2021 at 8:02 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Wed, Apr 14, 2021 at 9:41 AM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest <revest@xxxxxxxxxxxx> wrote: > > > + fmt = (char *)fmt_addr + fmt_map_off; > > > + > > > > bot complained about lack of (long) cast before fmt_addr, please address > > (uintptr_t), I assume? (uintptr_t) seems more correct to me as well. However, I just had a look at the rest of verifier.c and (long) casts are already used pretty much everywhere whereas uintptr_t isn't used yet. I'll send a v4 with a long cast for the sake of consistency with the rest of the verifier.