On Mon, Apr 12, 2021 at 2:56 PM Ilya Leoshkevich <iii@xxxxxxxxxxxxx> wrote: > > pahole v1.21 supports the --btf_gen_floats flag, which makes it > generate the information about the floating-point types [1]. > > Adjust link-vmlinux.sh to pass this flag to pahole in case it's > supported, which is determined using a simple version check. > > [1] https://lore.kernel.org/dwarves/YHRiXNX1JUF2Az0A@xxxxxxxxxx/ > > Signed-off-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx> > --- few nits below, but otherwise looks good: Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > scripts/link-vmlinux.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index 3b261b0f74f0..392c7fb94d3e 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -227,8 +227,13 @@ gen_btf() > > vmlinux_link ${1} > > + local extra_paholeopt= let's keep variables together, can you move it up to `local pahole_ver` above? btw, does it need `=`, or `local paholeopt` will just create it as an empty variable? > + if [ "${pahole_ver}" -ge "121" ]; then > + extra_paholeopt="${extra_paholeopt} --btf_gen_floats" > + fi > + > info "BTF" ${2} > - LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${1} > + LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J${extra_paholeopt} ${1} it looks weird that there is no space between -J and $extra_paholeopt, why complicating things? extra space isn't a big deal in command invocation, imo > > # Create ${2} which contains just .BTF section but no symbols. Add > # SHF_ALLOC because .BTF will be part of the vmlinux image. --strip-all > -- > 2.29.2 >
