On Fri, Apr 2, 2021 at 10:12 PM Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote: > > On Wed, Mar 31, 2021 at 11:01 PM John Fastabend > <john.fastabend@xxxxxxxxx> wrote: > > This 'else if' is always true if above is false right? Would be > > impler and clearer IMO as, > > > > if (used <= 0) { > > if (!copied) > > copied = used; > > break; > > } > > copied += used; > > > > I don't see anyway for used to be great than skb->len. > > Yes, slightly better. Please feel free to submit a patch by yourself, > like always your patches are welcome. Please submit a follow up patch as John requested or I'm reverting your set.