Cong Wang wrote:
> From: Cong Wang <cong.wang@xxxxxxxxxxxxx>
>
> Now UDP supports sockmap and redirection, we can safely update
> the sock type checks for it accordingly.
>
> Cc: John Fastabend <john.fastabend@xxxxxxxxx>
> Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
> Cc: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> Cc: Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
> Signed-off-by: Cong Wang <cong.wang@xxxxxxxxxxxxx>
> ---
> net/core/sock_map.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/sock_map.c b/net/core/sock_map.c
> index d04b98fc8104..9ed040c7d9e7 100644
> --- a/net/core/sock_map.c
> +++ b/net/core/sock_map.c
> @@ -549,7 +549,10 @@ static bool sk_is_udp(const struct sock *sk)
>
> static bool sock_map_redirect_allowed(const struct sock *sk)
> {
> - return sk_is_tcp(sk) && sk->sk_state != TCP_LISTEN;
> + if (sk_is_tcp(sk))
> + return sk->sk_state != TCP_LISTEN;
> + else
> + return sk->sk_state == TCP_ESTABLISHED;
> }
>
> static bool sock_map_sk_is_suitable(const struct sock *sk)
> --
> 2.25.1
>
I think its a bit odd for TCP_ESTABLISHED to work with !tcp, but
thats not your invention so LGTM.
Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>
