This series fixes some issues around socket creation for AF_XDP. Patch 1 fixes a potential NULL pointer dereference in xsk_socket__create_shared. Patch 2 ensures that the umem passed to xsk_socket__create(_shared) remains unchanged in event of failure. Patch 3 makes it possible for xsk_socket__create(_shared) to succeed even if the rx and tx XDP rings have already been set up, by ignoring the return value of the XDP_RX_RING/XDP_TX_RING setsockopt. This removes a limitation which existed whereby a user could not retry socket creation after a previous failed attempt. It was chosen to solve the problem by ignoring the return values in libbpf instead of modifying the setsockopt handling code in the kernel in order to make it possible for the solution to be available across all kernels, provided a new enough libbpf is available. This series applies on commit 87d77e59d1ebc31850697341ab15ca013004b81b Ciara Loftus (3): libbpf: ensure umem pointer is non-NULL before dereferencing libbpf: restore umem state after socket create failure libbpf: ignore return values of setsockopt for XDP rings. tools/lib/bpf/xsk.c | 66 +++++++++++++++++++++++++-------------------- 1 file changed, 37 insertions(+), 29 deletions(-) -- 2.17.1
