On Mon, Mar 22, 2021 at 11:33 AM KP Singh <kpsingh@xxxxxxxxxx> wrote:
>
> On Mon, Mar 22, 2021 at 6:54 PM Andrii Nakryiko
> <andrii.nakryiko@xxxxxxxxx> wrote:
> >
> > On Mon, Mar 22, 2021 at 9:37 AM KP Singh <kpsingh@xxxxxxxxxx> wrote:
> > >
> > > The newly introduced -s command line option starts an interactive shell
> > > after running the intended command in instead of powering off the VM.
> > > It's useful to have a shell especially when debugging failing
> > > tests or developing new tests.
> > >
> > > Signed-off-by: KP Singh <kpsingh@xxxxxxxxxx>
> > > ---
> > > tools/testing/selftests/bpf/vmtest.sh | 15 +++++++++++----
> > > 1 file changed, 11 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/tools/testing/selftests/bpf/vmtest.sh b/tools/testing/selftests/bpf/vmtest.sh
> > > index 22554894db99..3f248e755755 100755
> > > --- a/tools/testing/selftests/bpf/vmtest.sh
> > > +++ b/tools/testing/selftests/bpf/vmtest.sh
> > > @@ -24,7 +24,7 @@ EXIT_STATUS_FILE="${LOG_FILE_BASE}.exit_status"
> > > usage()
> > > {
> > > cat <<EOF
> > > -Usage: $0 [-i] [-d <output_dir>] -- [<command>]
> > > +Usage: $0 [-i] [-s] [-d <output_dir>] -- [<command>]
> >
> > wouldn't it make more sense to just run bash without any default
> > commands, if -s is specified? So "shell mode" gets you into shell.
> > Then you can run whatever you want.
> >
>
> Yep, that would be better indeed. Will send an updated v2.
Cool. If it's not too hard, it still makes sense to run <command> in
bash, if it was specified explicitly.
