Re: [PATCH] bpf: Add getter and setter for SO_REUSEPORT through bpf_{g,s}etsockopt

[Daniel Borkmann <daniel@xxxxxxxxxxxxx>]

On 3/10/21 7:23 PM, Manu Bretelle wrote:
> Augment the current set of options that are accessible via
> bpf_{g,s}etsockopt to also support SO_REUSEPORT.
>
> Signed-off-by: Manu Bretelle <chantra@xxxxxx>

Applied, thanks! I fixed up the 4 extra newlines:

> diff --git a/tools/testing/selftests/bpf/progs/bind4_prog.c b/tools/testing/selftests/bpf/progs/bind4_prog.c
> index 115a3b0ad984..b65a5e2481e6 100644
> --- a/tools/testing/selftests/bpf/progs/bind4_prog.c
> +++ b/tools/testing/selftests/bpf/progs/bind4_prog.c
> @@ -57,6 +57,29 @@ static __inline int bind_to_device(struct bpf_sock_addr *ctx)
>   	return 0;
>   }
>   
> +static __inline int bind_reuseport(struct bpf_sock_addr *ctx)
> +{
> +

^^^ here

> +	int val = 1;
> +
> +	if (bpf_setsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)))
> +		return 1;
> +	if (bpf_getsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)) || !val)
> +		return 1;
> +	val = 0;
> +	if (bpf_setsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)))
> +		return 1;
> +	if (bpf_getsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)) || val)
> +		return 1;
> +
> +

^^^ here

> +	return 0;
> +}
> +
>   static __inline int misc_opts(struct bpf_sock_addr *ctx, int opt)
>   {
[...]
> diff --git a/tools/testing/selftests/bpf/progs/bind6_prog.c b/tools/testing/selftests/bpf/progs/bind6_prog.c
> index 4c0d348034b9..68e7ede67b6d 100644
> --- a/tools/testing/selftests/bpf/progs/bind6_prog.c
> +++ b/tools/testing/selftests/bpf/progs/bind6_prog.c
> @@ -63,6 +63,29 @@ static __inline int bind_to_device(struct bpf_sock_addr *ctx)
>   	return 0;
>   }
>   
> +static __inline int bind_reuseport(struct bpf_sock_addr *ctx)
> +{
> +

^^^ here

> +	int val = 1;
> +
> +	if (bpf_setsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)))
> +		return 1;
> +	if (bpf_getsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)) || !val)
> +		return 1;
> +	val = 0;
> +	if (bpf_setsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)))
> +		return 1;
> +	if (bpf_getsockopt(ctx, SOL_SOCKET, SO_REUSEPORT,
> +			   &val, sizeof(val)) || val)
> +		return 1;
> +
> +

^^^ here

> +	return 0;
> +}
> +
>   static __inline int misc_opts(struct bpf_sock_addr *ctx, int opt)
>   {
>   	int old, tmp, new = 0xeb9f;