Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg
From: Cong Wang <xiyou.wangcong@xxxxxxxxx>
Date: Thu, 11 Mar 2021 16:45:05 -0800
Cc: Linux Kernel Network Developers <netdev@xxxxxxxxxxxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, duanxiongchun@xxxxxxxxxxxxx, Dongdong Wang <wangdongdong.6@xxxxxxxxxxxxx>, Jiang Wang <jiang.wang@xxxxxxxxxxxxx>, Cong Wang <cong.wang@xxxxxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
In-reply-to: <871rcm3p6m.fsf@cloudflare.com>

On Thu, Mar 11, 2021 at 3:28 AM Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> wrote:
> > +
> > +static inline struct sk_msg *sk_psock_deque_msg(struct sk_psock *psock)
>
> Should be sk_psock_deque*ue*_msg()?

Right, it is better and less confusing to use "dequeue".

Thanks.

References:
- [Patch bpf-next v4 00/11] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP
  - From: Cong Wang
- [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg
  - From: Cong Wang
- Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg
  - From: Jakub Sitnicki

Prev by Date: [PATCH dwarves] btf: Add --btf_gen_all flag
Next by Date: Re: [Patch bpf-next v4 03/11] skmsg: introduce skb_send_sock() for sock_map
Previous by thread: Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg
Next by thread: [Patch bpf-next v4 07/11] udp: implement ->read_sock() for sockmap
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]

Powered by Linux