> -----Original Message----- > From: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > Sent: Monday, March 8, 2021 13:07 > To: bpf@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; > ast@xxxxxxxxxx; daniel@xxxxxxxxxxxxx; brouer@xxxxxxxxxx; > toke@xxxxxxxxxx; freysteinn.alfredsson@xxxxxx; > lorenzo.bianconi@xxxxxxxxxx; john.fastabend@xxxxxxxxx; > jasowang@xxxxxxxxxx; mst@xxxxxxxxxx; thomas.petazzoni@xxxxxxxxxxx; > mw@xxxxxxxxxxxx; linux@xxxxxxxxxxxxxxx; ilias.apalodimas@xxxxxxxxxx; > netanel@xxxxxxxxxx; akiyano@xxxxxxxxxx; > michael.chan@xxxxxxxxxxxx; Madalin Bucur <madalin.bucur@xxxxxxx>; > Ioana Ciornei <ioana.ciornei@xxxxxxx>; jesse.brandeburg@xxxxxxxxx; > anthony.l.nguyen@xxxxxxxxx; saeedm@xxxxxxxxxx; > grygorii.strashko@xxxxxx; ecree.xilinx@xxxxxxxxx; > maciej.fijalkowski@xxxxxxxxx > Subject: [PATCH v3 bpf-next] bpf: devmap: move drop error path to devmap > for XDP_REDIRECT > > We want to change the current ndo_xdp_xmit drop semantics because > it will allow us to implement better queue overflow handling. > This is working towards the larger goal of a XDP TX queue-hook. > Move XDP_REDIRECT error path handling from each XDP ethernet driver to > devmap code. According to the new APIs, the driver running the > ndo_xdp_xmit pointer, will break tx loop whenever the hw reports a tx > error and it will just return to devmap caller the number of successfully > transmitted frames. It will be devmap responsability to free dropped > frames. > Move each XDP ndo_xdp_xmit capable driver to the new APIs: > - veth > - virtio-net > - mvneta > - mvpp2 > - socionext > - amazon ena > - bnxt > - freescale (dpaa2, dpaa) > - xen-frontend > - qede > - ice > - igb > - ixgbe > - i40e > - mlx5 > - ti (cpsw, cpsw-new) > - tun > - sfc > > Acked-by: Edward Cree <ecree.xilinx@xxxxxxxxx> > Reviewed-by: Ioana Ciornei <ioana.ciornei@xxxxxxx> > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> For the dpaa driver: Reviewed-by: Camelia Groza <camelia.groza@xxxxxxx>
