On Wed, Mar 3, 2021 at 3:04 AM Brendan Jackman <jackmanb@xxxxxxxxxx> wrote: > > Note this still goes on top of Ilya's patch: > > https://lore.kernel.org/bpf/20210301154019.129110-1-iii@xxxxxxxxxxxxx/T/#u It didn't. I had to manually patch it in. > +static bool is_cmpxchg_insn(const struct bpf_insn *insn) > +{ > + return (BPF_CLASS(insn->code) == BPF_STX && > + BPF_MODE(insn->code) == BPF_ATOMIC && > + insn->imm == BPF_CMPXCHG); > +} I've also removed unnecessary () and applied to "bpf" tree. Thanks!