Re: [PATCH bpf 2/3] samples: bpf: add missing munmap in xdpsock

[Björn Töpel <bjorn.topel@xxxxxxxxx>]

On 2021-03-03 16:51, Maciej Fijalkowski wrote:
> We mmap the umem region, but we never munmap it.
> Add the missing call at the end of the cleanup.
>
> Fixes: 3945b37a975d ("samples/bpf: use hugepages in xdpsock app")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>

Acked-by: Björn Töpel <bjorn.topel@xxxxxxxxx>

> ---
>   samples/bpf/xdpsock_user.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
> index db0cb73513a5..1e2a1105d0e6 100644
> --- a/samples/bpf/xdpsock_user.c
> +++ b/samples/bpf/xdpsock_user.c
> @@ -1699,5 +1699,7 @@ int main(int argc, char **argv)
>   
>   	xdpsock_cleanup();
>   
> +	munmap(bufs, NUM_FRAMES * opt_xsk_frame_size);
> +
>   	return 0;
>   }