On Tue, 2 Mar 2021 at 02:38, Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote: > > From: Cong Wang <cong.wang@xxxxxxxxxxxxx> > > Add a test case to ensure redirection between two UDP sockets work. I basically don't understand how splicing works, but watching from the sidelines makes me think it'd be good to have more thorough tests. tools/testing/selftests/bpf/test_sockmap.c has quite elaborate tests for the TCP part, it'd be nice to get similar tests going for UDP. For example: * sendfile? * sendmmsg * Something Jakub mentioned: what happens when a connected, spliced socket is disconnected via connect(AF_UNSPEC)? Seems like we don't hook sk_prot->disconnect anywhere. -- Lorenz Bauer | Systems Engineer 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK www.cloudflare.com