On 2/23/21 3:43 PM, Jesper Dangaard Brouer wrote:
On Tue, 23 Feb 2021 20:45:54 +0800 Hangbin Liu <liuhangbin@xxxxxxxxx> wrote:Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") lost a * in bpf.h. This will make bpf_helpers_doc.py stop building bpf_helper_defs.h immediately after bpf_check_mtu, which will affect future add functions. Fixes: 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx> --- include/uapi/linux/bpf.h | 2 +- tools/include/uapi/linux/bpf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)Thanks for fixing that! Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
Thanks guys, applied!
I though I had already fix that, but I must have missed or reintroduced this, when I rolling back broken ideas in V13. I usually run this command to check the man-page (before submitting): ./scripts/bpf_helpers_doc.py | rst2man | man -l -
[+ Andrii] maybe this could be included to run as part of CI to catch such things in advance?
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 4c24daa43bac..46248f8e024b 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -3850,7 +3850,7 @@ union bpf_attr { * * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags) * Description - + * * Check ctx packet size against exceeding MTU of net device (based * on *ifindex*). This helper will likely be used in combination * with helpers that adjust/change the packet size. diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 4c24daa43bac..46248f8e024b 100644 --- a/tools/include/uapi/linux/bpf.h +++ b/tools/include/uapi/linux/bpf.h @@ -3850,7 +3850,7 @@ union bpf_attr { * * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags) * Description - + * * Check ctx packet size against exceeding MTU of net device (based * on *ifindex*). This helper will likely be used in combination * with helpers that adjust/change the packet size.
