On Tue, 23 Feb 2021 21:14:57 +0800
Hangbin Liu <liuhangbin@xxxxxxxxx> wrote:
> Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") added an
> extra blank line in bpf helper description. This will make
> bpf_helpers_doc.py stop building bpf_helper_defs.h immediately after
> bpf_check_mtu, which will affect future add functions.
>
> Fixes: 34b2021cc616 ("bpf: Add BPF-helper for MTU checking")
> Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
> ---
> v2: remove the blank line directly instead of adding a *
> ---
> include/uapi/linux/bpf.h | 1 -
> tools/include/uapi/linux/bpf.h | 1 -
> 2 files changed, 2 deletions(-)
Acked-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 4c24daa43bac..79c893310492 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -3850,7 +3850,6 @@ union bpf_attr {
> *
> * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags)
> * Description
> -
> * Check ctx packet size against exceeding MTU of net device (based
> * on *ifindex*). This helper will likely be used in combination
> * with helpers that adjust/change the packet size.
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 4c24daa43bac..79c893310492 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -3850,7 +3850,6 @@ union bpf_attr {
> *
> * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags)
> * Description
> -
> * Check ctx packet size against exceeding MTU of net device (based
> * on *ifindex*). This helper will likely be used in combination
> * with helpers that adjust/change the packet size.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
