On Sat, Feb 20, 2021 at 06:29 AM CET, Cong Wang wrote:
> From: Cong Wang <cong.wang@xxxxxxxxxxxxx>
>
> These two eBPF programs are tied to BPF_SK_SKB_STREAM_PARSER
> and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact
> they are only used for TCP. And save the name 'skb_verdict' for
> general use later.
>
> Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
> Cc: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> Reviewed-by: Lorenz Bauer <lmb@xxxxxxxxxxxxxx>
> Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>
> Signed-off-by: Cong Wang <cong.wang@xxxxxxxxxxxxx>
> ---
skb_parser also appears in:
tools/testing/selftests/bpf/test_sockmap.c:int txmsg_omit_skb_parser;
tools/testing/selftests/bpf/test_sockmap.c: {"txmsg_omit_skb_parser", no_argument, &txmsg_omit_skb_parser, 1},
tools/testing/selftests/bpf/test_sockmap.c: txmsg_omit_skb_parser = 0;
tools/testing/selftests/bpf/test_sockmap.c: if (!txmsg_omit_skb_parser) {
tools/testing/selftests/bpf/test_sockmap.c: if (!txmsg_omit_skb_parser) {
tools/testing/selftests/bpf/test_sockmap.c: /* Tests that omit skb_parser */
tools/testing/selftests/bpf/test_sockmap.c: txmsg_omit_skb_parser = 1;
tools/testing/selftests/bpf/test_sockmap.c: txmsg_omit_skb_parser = 0;
But I understand that changing the option name could break scripts or CI
setups. And even if that's not the case it can be cleanup up later.
Acked-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
