Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions

[Björn Töpel <bjorn.topel@xxxxxxxxx>]

On 2021-02-19 18:10, Toke Høiland-Jørgensen wrote:
> > +	case XDP_REDIR_DEV_MAP: {
> >   		struct bpf_dtab_netdev *dst = fwd;
> I thought the braces around the case body looked a bit odd. I guess
> that's to get a local scope for the dst var (and xs var below), right?
> This is basically a cast, though, so I wonder if you couldn't just as
> well use the fwd pointer directly (with a cast) in the function call
> below? WDYT?

Yeah. I'll fix that in the next verison!


Thanks, and have a nice weekend!
Björn