Re: [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to skb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Cong Wang wrote:
> On Wed, Feb 17, 2021 at 10:40 AM John Fastabend
> <john.fastabend@xxxxxxxxx> wrote:
> > > @@ -802,9 +809,10 @@ int sk_psock_tls_strp_read(struct sk_psock *psock, struct sk_buff *skb)
> > >                * TLS context.
> > >                */
> > >               skb->sk = psock->sk;
> > > -             tcp_skb_bpf_redirect_clear(skb);
> > > +             skb_dst_drop(skb);
> > > +             skb_bpf_redirect_clear(skb);
> >
> > Do we really need the skb_dst_drop() I thought we would have already dropped this here
> > but I've not had time to check yet.
> 
> Yes, I got some serious complaints from dst_release() when I didn't
> add skb_dst_drop().
> 
> Thanks.

OK thanks.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux