On Wed, 17 Feb 2021 at 02:43, KP Singh <kpsingh@xxxxxxxxxx> wrote: > > On Wed, Feb 17, 2021 at 1:50 AM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote: > > > > On 2/16/21 3:19 PM, Brendan Jackman wrote: [...] > > Looks good overall, one small nit ... is it possible to move this into fixup_bpf_calls() > > where we walk the prog insns & handle most of the rewrites already? > > Ah, so I thought fixup_bpf_calls was for "calls" but now looking at > the function it does > more than just fixing up calls. I guess we could also rename it and > update the comment > on the function. Ah yes. Looks like we have: - Some division-by-zero related stuff - Implementation of LD_ABS/LD_IND - Some spectre mitigation - Tail calls - Fixups for map and jiffies helper calls How about I rename this function to do_misc_fixups and add a short comment to each of the above sections outlining what they're doing?
