Re: [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 16, 2021 at 10:22:15AM +0100, Björn Töpel wrote:
> On 2021-02-15 21:24, John Fastabend wrote:
> > Maciej Fijalkowski wrote:
> > > With the introduction of bpf_link in xsk's libbpf part, there's no
> > > further need for explicit unload of prog on xdpsock's termination. When
> > > process dies, the bpf_link's refcount will be decremented and resources
> > > will be unloaded/freed under the hood in case when there are no more
> > > active users.
> > > 
> > > While at it, don't dump stats on error path.
> > > 
> > > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
> > > ---
> > 
> > Can we also use it from selftests prog so we have a test that is run there
> > using this? Looks like xdpxceiver.c could do the link step as well?
> > 
> 
> Yes! Good point!

Somehow John's mail didn't end up in my inbox.
xdpxceiver is using libbpf API for socket handling (create/delete), so
with that set included it is working on bpf_link.

> 
> 
> Björn



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux