On Fri, Feb 12, 2021 at 11:48 AM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote:
> >
> > There is what I see after compiling the kernel:
>
> typo: This?
Yes, sure.
> > # bpf-next...bpf-next/master
> > ?? tools/bpf/resolve_btfids/libbpf/
> >
> > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
> > ---
>
> Jiri,
>
> Is this
>
> Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
> in separate directories")
>
> ?
>
> Do we need similar stuff for libsubcmd (what's that, btw?)
It's probably not needed because it has only .o files in there (.o are
ignored in the root .gitignore).
I assume libbpf/ has an issue because there is bpf_helper_defs.h in
that libbpf/ directory.
Not sure why it was removed in fc6b48f692f8 rather than being prefixed
with libbpf/ directory.
I'll leave it up to Jiri to comment.
> > tools/bpf/resolve_btfids/.gitignore | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> > index 25f308c933cc..16913fffc985 100644
> > --- a/tools/bpf/resolve_btfids/.gitignore
> > +++ b/tools/bpf/resolve_btfids/.gitignore
> > @@ -1,2 +1,3 @@
> > /fixdep
> > /resolve_btfids
> > +/libbpf/
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
