On Fri, 29 Jan 2021 12:07:23 -0800 Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote: > > On 1/29/21 8:35 PM, Jakub Kicinski wrote: > > > > > kdoc didn't complain, and as you say it's already a mess, plus it's > > > two screen-fulls of scrolling away... > > > > > > I think converting to inline kdoc of members would be an improvement, > > > if you want to sign up for that? Otherwise -EDIDNTCARE on my side :) > > > > > > > What about removing this kdoc ? > > > > kdoc for a huge structure is mostly useless... > > It's definitely not useful for "us", I'd guess most seasoned developers > will just grep for uses of the field - but maybe it is useful for noobs > trying to have high-level sense of the code? > > Either way is fine by me, we can always preserve meaningful comments > inline without the kdoc decorator. I agree that removing this kdoc makes sense. But as Jakub says we should preserve meaningful comments inline. I'll add this task to my TODO list, but anyone feel free to do the work before I get around to it. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
