Re: [PATCH bpf-next v3 1/6] xsk: add tracepoints for packet drops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ciara,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Ciara-Loftus/AF_XDP-Packet-Drop-Tracing/20210203-020056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-r015-20210202 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/8566dfd5799adb0033d56bc33146947b9469c362
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ciara-Loftus/AF_XDP-Packet-Drop-Tracing/20210203-020056
        git checkout 8566dfd5799adb0033d56bc33146947b9469c362
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   kernel/bpf/core.c:1350:12: warning: no previous prototype for function 'bpf_probe_read_kernel' [-Wmissing-prototypes]
   u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr)
              ^
   kernel/bpf/core.c:1350:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr)
   ^
   static 
   In file included from kernel/bpf/core.c:2361:
   In file included from include/linux/bpf_trace.h:6:
   In file included from include/trace/events/xsk.h:73:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:401:
>> include/trace/events/xsk.h:65:34: warning: format specifies type 'unsigned long' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
                     print_val1(__entry->reason), __entry->val1,
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
   include/trace/trace_events.h:263:17: note: expanded from macro '__entry'
   #define __entry field
                   ^
   include/trace/trace_events.h:266:43: note: expanded from macro 'TP_printk'
   #define TP_printk(fmt, args...) fmt "\n", args
                                   ~~~       ^
   include/trace/trace_events.h:80:16: note: expanded from macro 'TRACE_EVENT'
                                PARAMS(print));                   \
                                ~~~~~~~^~~~~~~
   include/linux/tracepoint.h:97:25: note: expanded from macro 'PARAMS'
   #define PARAMS(args...) args
                           ^~~~
   include/trace/trace_events.h:367:22: note: expanded from macro 'DECLARE_EVENT_CLASS'
           trace_seq_printf(s, print);                                     \
                               ^~~~~
   In file included from kernel/bpf/core.c:2361:
   In file included from include/linux/bpf_trace.h:6:
   In file included from include/trace/events/xsk.h:73:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:401:
   include/trace/events/xsk.h:66:34: warning: format specifies type 'unsigned long' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
                     print_val2(__entry->reason), __entry->val2,
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
   include/trace/trace_events.h:263:17: note: expanded from macro '__entry'
   #define __entry field
                   ^
   include/trace/trace_events.h:266:43: note: expanded from macro 'TP_printk'
   #define TP_printk(fmt, args...) fmt "\n", args
                                   ~~~       ^
   include/trace/trace_events.h:80:16: note: expanded from macro 'TRACE_EVENT'
                                PARAMS(print));                   \
                                ~~~~~~~^~~~~~~
   include/linux/tracepoint.h:97:25: note: expanded from macro 'PARAMS'
   #define PARAMS(args...) args
                           ^~~~
   include/trace/trace_events.h:367:22: note: expanded from macro 'DECLARE_EVENT_CLASS'
           trace_seq_printf(s, print);                                     \
                               ^~~~~
   In file included from kernel/bpf/core.c:2361:
   In file included from include/linux/bpf_trace.h:6:
   In file included from include/trace/events/xsk.h:73:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:401:
   include/trace/events/xsk.h:67:34: warning: format specifies type 'unsigned long' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
                     print_val3(__entry->reason), __entry->val3
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
   include/trace/trace_events.h:263:17: note: expanded from macro '__entry'
   #define __entry field
                   ^
   include/trace/trace_events.h:266:43: note: expanded from macro 'TP_printk'
   #define TP_printk(fmt, args...) fmt "\n", args
                                   ~~~       ^
   include/trace/trace_events.h:80:16: note: expanded from macro 'TRACE_EVENT'
                                PARAMS(print));                   \
                                ~~~~~~~^~~~~~~
   include/linux/tracepoint.h:97:25: note: expanded from macro 'PARAMS'
   #define PARAMS(args...) args
                           ^~~~
   include/trace/trace_events.h:367:22: note: expanded from macro 'DECLARE_EVENT_CLASS'
           trace_seq_printf(s, print);                                     \
                               ^~~~~
   4 warnings generated.


vim +65 include/trace/events/xsk.h

    40	
    41		TP_PROTO(char *name, u16 queue_id, u32 reason, u64 val1, u64 val2, u64 val3),
    42	
    43		TP_ARGS(name, queue_id, reason, val1, val2, val3),
    44	
    45		TP_STRUCT__entry(
    46			__field(char *, name)
    47			__field(u16, queue_id)
    48			__field(u32, reason)
    49			__field(u64, val1)
    50			__field(u64, val2)
    51			__field(u64, val3)
    52		),
    53	
    54		TP_fast_assign(
    55			__entry->name = name;
    56			__entry->queue_id = queue_id;
    57			__entry->reason = reason;
    58			__entry->val1 = val1;
    59			__entry->val2 = val2;
    60			__entry->val3 = val3;
    61		),
    62	
    63		TP_printk("netdev: %s qid %u reason: %s: %s %lu %s %lu %s %lu",
    64			  __entry->name, __entry->queue_id, print_reason(__entry->reason),
  > 65			  print_val1(__entry->reason), __entry->val1,
    66			  print_val2(__entry->reason), __entry->val2,
    67			  print_val3(__entry->reason), __entry->val3
    68		)
    69	);
    70	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux