On Mon, Jan 25, 2021 at 01:27:24PM +0100, Maciej Fijalkowski wrote: > Hangbin, > > before you submit next revision, could you try to apply imperative mood to > your commit messages? > > From Documentation/process/submitting-patches.rst: > > <quote> > Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > to do frotz", as if you are giving orders to the codebase to change > its behaviour. > </quote> > > That's the thing I'm trying to remind people internally and it feels like > we keep on forgetting about that. Hi Maciej, Thanks for the reminder. I just see your reply after post the new version. As I'm not a native speaker, I always not very sure what kind of mood/words I should use in the commit message. So I just try to as polite as possible (although I may pick some rude works that I didn't realize) and not order people or something else based on our culture/background. I guess that's also the reason some people forget to use "imperative mood". I will keep this in mind for future works. Thanks Hangbin
