Hi Qais, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-rhel-8.3 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/8f02e2ee2ac949ce6b4fd3cfd323f2e513a2cac6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Qais-Yousef/Allow-attaching-to-bare-tracepoints/20210112-022350 git checkout 8f02e2ee2ac949ce6b4fd3cfd323f2e513a2cac6 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/trace/define_trace.h:104, from include/trace/events/sched.h:740, from kernel/sched/core.c:10: >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:693:1: note: in expansion of macro 'DECLARE_TRACE' 693 | DECLARE_TRACE(pelt_cfs_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:697:1: note: in expansion of macro 'DECLARE_TRACE' 697 | DECLARE_TRACE(pelt_rt_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:701:1: note: in expansion of macro 'DECLARE_TRACE' 701 | DECLARE_TRACE(pelt_dl_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:705:1: note: in expansion of macro 'DECLARE_TRACE' 705 | DECLARE_TRACE(pelt_thermal_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:709:1: note: in expansion of macro 'DECLARE_TRACE' 709 | DECLARE_TRACE(pelt_irq_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:713:1: note: in expansion of macro 'DECLARE_TRACE' 713 | DECLARE_TRACE(pelt_se_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:717:1: note: in expansion of macro 'DECLARE_TRACE' 717 | DECLARE_TRACE(sched_cpu_capacity_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:721:1: note: in expansion of macro 'DECLARE_TRACE' 721 | DECLARE_TRACE(sched_overutilized_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:725:1: note: in expansion of macro 'DECLARE_TRACE' 725 | DECLARE_TRACE(sched_util_est_cfs_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:729:1: note: in expansion of macro 'DECLARE_TRACE' 729 | DECLARE_TRACE(sched_util_est_se_tp, | ^~~~~~~~~~~~~ >> include/trace/bpf_probe.h:59:1: error: expected identifier or '(' before 'static' 59 | static notrace void \ | ^~~~~~ include/trace/bpf_probe.h:119:3: note: in expansion of macro '__BPF_DECLARE_TRACE' 119 | (__BPF_DECLARE_TRACE(call, PARAMS(proto), PARAMS(args)) \ | ^~~~~~~~~~~~~~~~~~~ include/trace/events/sched.h:733:1: note: in expansion of macro 'DECLARE_TRACE' 733 | DECLARE_TRACE(sched_update_nr_running_tp, | ^~~~~~~~~~~~~ kernel/sched/core.c:2828:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes] 2828 | void sched_set_stop_task(int cpu, struct task_struct *stop) | ^~~~~~~~~~~~~~~~~~~ kernel/sched/core.c: In function 'schedule_tail': kernel/sched/core.c:4238:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable] 4238 | struct rq *rq; | ^~ vim +59 include/trace/bpf_probe.h c4f6699dfcb855 Alexei Starovoitov 2018-03-28 57 8f02e2ee2ac949 Qais Yousef 2021-01-11 58 #define __BPF_DECLARE_TRACE(call, proto, args) \ c4f6699dfcb855 Alexei Starovoitov 2018-03-28 @59 static notrace void \ c4f6699dfcb855 Alexei Starovoitov 2018-03-28 60 __bpf_trace_##call(void *__data, proto) \ c4f6699dfcb855 Alexei Starovoitov 2018-03-28 61 { \ c4f6699dfcb855 Alexei Starovoitov 2018-03-28 62 struct bpf_prog *prog = __data; \ c4f6699dfcb855 Alexei Starovoitov 2018-03-28 63 CONCATENATE(bpf_trace_run, COUNT_ARGS(args))(prog, CAST_TO_U64(args)); \ c4f6699dfcb855 Alexei Starovoitov 2018-03-28 64 } c4f6699dfcb855 Alexei Starovoitov 2018-03-28 65 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
