On Wed, Dec 23, 2020 at 5:14 PM Jiang Wang <jiang.wang@xxxxxxxxxxxxx> wrote: > > When CONFIG_BPF_LSM is not configured, running bpf selftesting will show > BPF_F_BPRM_SECUREEXEC undefined error for bprm_opts.c. > > The problem is that bprm_opts.c includes vmliunx.h. The vmlinux.h is > generated by "bpftool btf dump file ./vmlinux format c". On the other > hand, BPF_F_BPRM_SECUREEXEC is defined in include/uapi/linux/bpf.h > and used only in bpf_lsm.c. When CONFIG_BPF_LSM is not set, bpf_lsm > will not be compiled, so vmlinux.h will not include definition of > BPF_F_BPRM_SECUREEXEC. > > Ideally, we want to compile bpf selftest regardless of the configuration > setting, so change the include file from vmlinux.h to bpf.h. > > Signed-off-by: Jiang Wang <jiang.wang@xxxxxxxxxxxxx> btw: for future patches, please prefix the subject as [PATCH bpf] or [PATCH bpf-next], so it is clear which tree the patch applies to. In this case, this should be bpf tree. Thanks, Song > --- > tools/testing/selftests/bpf/progs/bprm_opts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/progs/bprm_opts.c b/tools/testing/selftests/bpf/progs/bprm_opts.c > index 5bfef2887e70..418d9c6d4952 100644 > --- a/tools/testing/selftests/bpf/progs/bprm_opts.c > +++ b/tools/testing/selftests/bpf/progs/bprm_opts.c > @@ -4,7 +4,7 @@ > * Copyright 2020 Google LLC. > */ > > -#include "vmlinux.h" > +#include <linux/bpf.h> > #include <errno.h> > #include <bpf/bpf_helpers.h> > #include <bpf/bpf_tracing.h> > -- > 2.11.0 >
