On Tue, Dec 22, 2020 at 1:09 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote: > > Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize > xdp_buff data structure and remove duplicated code in all XDP capable > drivers. > > Changes since v4: > - fix xdp_init_buff/xdp_prepare_buff (natural order is xdp_init_buff() first > and then xdp_prepare_buff()) > > Changes since v3: > - use __always_inline instead of inline for xdp_init_buff/xdp_prepare_buff > - add 'const bool meta_valid' to xdp_prepare_buff signature to avoid > overwriting data_meta with xdp_set_data_meta_invalid() > - introduce removed comment in bnxt driver > > Changes since v2: > - precompute xdp->data as hard_start + headroom and save it in a local > variable to reuse it for xdp->data_end and xdp->data_meta in > xdp_prepare_buff() > > Changes since v1: > - introduce xdp_prepare_buff utility routine > > Lorenzo Bianconi (2): > net: xdp: introduce xdp_init_buff utility routine > net: xdp: introduce xdp_prepare_buff utility routine > > Acked-by: Shay Agroskin <shayagr@xxxxxxxxxx> > Acked-by: Martin Habets <habetsm.xilinx@xxxxxxxxx> > Acked-by: Camelia Groza <camelia.groza@xxxxxxx> The changes to the Intel drivers look fine to me, although it might be nice to have someone from Intel provide a review/ack. I've added intel-wired-lan to the thread so that someone from Intel can hopefully review and also ack this. Reviewed-by: Alexander Duyck <alexanderduyck@xxxxxx>
