On 12/10/20 5:28 PM, KP Singh wrote:
On Thu, Dec 10, 2020 at 5:18 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
[...]
It's hard and time-consuming enough to develop these features, I'd
rather keep selftests simpler, more manageable, and less brittle by
not having excessive amount of feature detection and skipped
selftests. I think that's the case for BPF atomics as well, btw (cc'ed
Yonghong and Brendan).
To alleviate some of the pain of setting up the environment, one way
would be to provide script and/or image to help bring up qemu VM for
easier testing. To that end, KP Singh (cc'ed) was able to re-use
libbpf CI's VM setup and make it easier for local development. I hope
he can share this soon.
I will clean it up and share it asap and send it as an RFC which
adds it to tools/testing/selftests/bpf
Thanks!
We can discuss on the RFC as to where the script would finally end up
but I think it would save a lot of time/back-and-forth if developers could
simply check:
"Does my change break the BPF CI?"
I'd love to have a Dockerfile under tools/testing/selftests/bpf/ that
replicates the CI env (e.g. busybox, nightly llvm, pahole git, etc) where
we could have quay.io job auto-build this for bpf / bpf-next tree e.g. from a
GH mirror. This would then allow to mount the local kernel tree as a volume
into the container for easy compilation & test access for everyone where we
then don't need all these workarounds like in this patch anymore.
Thanks,
Daniel
