On Thu, Dec 3, 2020 at 3:00 AM KP Singh <kpsingh@xxxxxxxxxxxx> wrote:
>
> On Thu, Dec 3, 2020 at 6:52 AM Andrii Nakryiko
> <andrii.nakryiko@xxxxxxxxx> wrote:
> >
> > On Wed, Dec 2, 2020 at 4:58 PM KP Singh <kpsingh@xxxxxxxxxxxx> wrote:
> > >
> > > From: KP Singh <kpsingh@xxxxxxxxxx>
> > >
> > > * losetup on busybox does not output the name of loop device on using
> > > -f with --show. It also dosn't support -j to find the loop devices
> >
> > typo: doesn't
>
> Fixed.
>
> >
> > > for a given backing file. losetup is updated to use "-a" which is
> > > available on busybox.
> > > * blkid does not support options (-s and -o) to only display the uuid.
> >
> > ... so parse it from full blkid output.
>
> Done.
>
> >
> > > * Not all environments have mkfs.ext4, the test requires a loop device
> > > with a backing image file which could formatted with any filesystem.
> > > Update to using mkfs.ext2 which is available on busybox.
> >
> > This one is great. It explains the problem, and what solution was
> > implemented, from the high-level. I'd just drop the " *" marks, it
> > makes it more pleasant to read as if it was written for humans, not
> > machines.
>
> I tend to use "* " for bullet points from the markdown syntax
> (as we use it heavily internally) I can avoid if you prefer / don't like it.
A list of bullet points don't read as a coherent text. It's not the
end of the world, but it's also not a common style here either.
>
>
> >
> > > Fixes: 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")
> > > Reported-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> > > Signed-off-by: KP Singh <kpsingh@xxxxxxxxxx>
> > > ---
> > > tools/testing/selftests/bpf/ima_setup.sh | 12 ++++++++----
> > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > >
> >
> > Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> >
> > > diff --git a/tools/testing/selftests/bpf/ima_setup.sh b/tools/testing/selftests/bpf/ima_setup.sh
> > > index 15490ccc5e55..137f2d32598f 100755
> > > --- a/tools/testing/selftests/bpf/ima_setup.sh
> > > +++ b/tools/testing/selftests/bpf/ima_setup.sh
> > > @@ -3,6 +3,7 @@
> > >
> >
> > [...]
