On Thu, Dec 3, 2020 at 3:02 AM KP Singh <kpsingh@xxxxxxxxxxxx> wrote: > > On Thu, Dec 3, 2020 at 6:46 AM Andrii Nakryiko > <andrii.nakryiko@xxxxxxxxx> wrote: > > > > On Wed, Dec 2, 2020 at 4:58 PM KP Singh <kpsingh@xxxxxxxxxxxx> wrote: > > > > > > From: KP Singh <kpsingh@xxxxxxxxxx> > > > > > > > Commit message is missing completely. > > I thought the subject is enough in this case to explain that we are > re-indenting the file. If there is nothing to add just copy paste the subject into commit log. > I can explain that this was missed because checkpatch.pl did not > complain about shell > scripts and that we would like to be consistent with the other shells scripts. checkpatch is a guidance. It's not a must have requirement. It works both ways. Sometimes we ignore checkpatch complaints. Sometimes we ask for things that checkpatch doesn't know about. Please respin at your earliest convenience. CI is suffering at the moment. It needs to be unbroken soon.
