On Wed, Dec 2, 2020 at 2:46 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Wed, Dec 2, 2020 at 9:52 AM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote: > > > > I've seen a situation, where a process that's under pprof constantly > > generates SIGPROF which prevents program loading indefinitely. > > The right thing to do probably is to disable signals in the upper > > layers while loading, but it still would be nice to get some error from > > libbpf instead of an endless loop. > > > > Let's add some small retry limit to the program loading: > > try loading the program 10 (arbitrary) times and give up. > > > > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx> > > --- > > The subject is misleading as hell. You are not adding retries, you are > limiting the number of retries. Ah, sorry, should've been s/add/cap/ :-( > Otherwise, LGTM. I'd probably go with an even smaller number, can't > imagine any normal use case having more than once EAGAIN. So I'd say > feel free to reduce it to 5 even. > > Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> Let me respin with a proper subject and 5 retries.
