On Fri, Nov 20, 2020 at 3:16 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> @@ -1257,6 +1258,13 @@ int begin_new_exec(struct linux_binprm * bprm)
> if (retval)
> goto out;
>
> + /* Ensure the files table is not shared. */
> + retval = unshare_files(&displaced);
> + if (retval)
> + goto out;
> + if (displaced)
> + put_files_struct(displaced);
It's not obvious from the patch (not enough context), but the new
placement seems to make much more sense - and it's where we do the
de-thread and switch the vm and signals too.
So this does seem to be the much more logical place.
Ack.
Linus
