On Thu, Nov 12, 2020 at 4:08 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > So I looked at your vmlinux image. I think we should just keep > everything mostly as it it right now (without changes in this patch), > but add just two simple checks: > > 1. Skip if fn->declaration (ignore correctly marked func declarations) > 2. Skip if DW_AT_inline: 1 (ignore inlined functions). > > I'd keep the named arguments check as is, I think it's helpful. 1) > will skip stuff that's explicitly marked as declaration. 2) inline > check will partially mitigate dropping of fn->external check (and we > can't really attach to inlined functions). I thought DW_AT_inline is an indication that the function was marked "inline" in C code. That doesn't mean that the function was actually inlined. So I don't think pahole should check that bit.
