On Tue, Nov 10, 2020 at 03:25:10PM +0100, Jesper Dangaard Brouer wrote: > On Tue, 10 Nov 2020 20:46:39 +0800 > Hangbin Liu <liuhangbin@xxxxxxxxx> wrote: > > > This patch add running xdp program on egress interface support for > > xdp_redirect_map sample. The new prog will change the IP ttl based > > on egress ifindex. > > > > Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx> > > --- > > samples/bpf/xdp_redirect_map_kern.c | 74 ++++++++++++++++++++++++++++- > > samples/bpf/xdp_redirect_map_user.c | 21 ++++---- > > Hmmm... I don't think is it a good idea to modify xdp_redirect_map this way. > > The xdp_redirect_map is used for comparative benchmarking and > mentioned+used in scientific articles. As far as I can see, this > change will default slowdown xdp_redirect_map performance, right? +1 User should be able to trigger attachment of this xdp egress prog by himself. I don't like having it as a mandatory thing on this sample. > > -- > Best regards, > Jesper Dangaard Brouer > MSc.CS, Principal Kernel Engineer at Red Hat > LinkedIn: http://www.linkedin.com/in/brouer >
