On Fri, 6 Nov 2020 09:24:48 +0100 Jiri Benc wrote: > On Thu, 5 Nov 2020 14:57:13 -0800, Jakub Kicinski wrote: > > If you're saying the driver message would still be there if > > verification or translation failed that's perfectly fine, we > > can definitely adjust the test. But some check that driver > > message reporting is working is needed, don't just remove it. > > Should we change the test to fail the verification? Sounds reasonable > to me. Yeah, you'd need a new debugfs knob in netdevsim to trigger the failure from instruction verification, then (to match where message is printed). And make the output validation a separate case, not just a check in some random success load.