On Wed, Oct 28, 2020 at 4:50 PM Alexander Duyck <alexander.duyck@xxxxxxxxx> wrote: > > From: Alexander Duyck <alexanderduyck@xxxxxx> > > Recently a bug was missed due to the fact that test_tcpbpf_user is not a > part of test_progs. In order to prevent similar issues in the future move > the test functionality into test_progs. By doing this we can make certain > that it is a part of standard testing and will not be overlooked. > > As a part of moving the functionality into test_progs it is necessary to > integrate with the test_progs framework and to drop any redundant code. > This patch: > 1. Cleans up the include headers > 2. Dropped a duplicate definition of bpf_find_map > 3. Replaced printf calls with fprintf to stderr > 4. Renamed main to test_tcpbpf_user > 5. Dropped return value in favor of CHECK calls to check for errors > > Signed-off-by: Alexander Duyck <alexanderduyck@xxxxxx> > --- > tools/testing/selftests/bpf/Makefile | 3 > .../testing/selftests/bpf/prog_tests/tcpbpf_user.c | 138 +++++++++++++++++ > tools/testing/selftests/bpf/test_tcpbpf_user.c | 165 -------------------- Please remove the binary from .gitignore as well > 3 files changed, 139 insertions(+), 167 deletions(-) > create mode 100644 tools/testing/selftests/bpf/prog_tests/tcpbpf_user.c > delete mode 100644 tools/testing/selftests/bpf/test_tcpbpf_user.c if this file is mostly the same, then Git should be able to detect that this is a file rename. That will be captured in a diff explicitly and will minimize this patch significantly. Please double-check why this was not detected properly. [...]
