On Mon, Oct 19, 2020 at 11:26 AM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > That wasn't happening last time people reported this on ARM32. > BPF_XADD was causing load failure, no fail back to interpreter mode. > > > > > Wrt force-interpret vs force-jit BPF_PROG_LOAD flag, I'm more concerned that this > > decision will then be pushed to the user who should not have to care about these > > internals. And how would generic loaders try to react if force-jit fails? They would > > then fallback to force-interpret same way as kernel does? > > The way I imagined this was if the user wants to force the mode and > the kernel doesn't support it (or the program can't be loaded in that > mode), then it's a fail-stop, no fall back. And it's strictly an > opt-in flag, if nothing is specified then it's current behavior with > fallback (which apparently doesn't always work). That doesn't sound right. Fallback to interpreter should always work unless features like trampoline are used. But that's not the case for arm32. Missing xadd support shouldn't cause load failure.
