Daniel Borkmann <daniel@xxxxxxxxxxxxx> writes: > On 10/15/20 5:46 PM, Toke Høiland-Jørgensen wrote: >> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> >> >> This updates the test_tc_neigh selftest to use the new syntax of >> bpf_redirect_neigh(). To exercise the helper both with and without the >> optional parameter, one forwarding direction is changed to do a >> bpf_fib_lookup() followed by a call to bpf_redirect_neigh(), while the >> other direction is using the map-based ifindex lookup letting the redirect >> helper resolve the nexthop from the FIB. >> >> This also fixes the test_tc_redirect.sh script to work on systems that have >> a consolidated dual-stack 'ping' binary instead of separate ping/ping6 >> versions. >> >> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > > I would prefer if you could not mix the two tests, meaning, one complete test > case is only with bpf_redirect_neigh(get_dev_ifindex(xxx), NULL, 0, 0) for both > directions, and another self-contained one is with fib lookup + bpf_redirect_neigh > with params, even if it means we duplicate test_tc_neigh.c slighly, but I think > that's fine for sake of test coverage. Sure, can do :) -Toke
