On Thu, Oct 8, 2020 at 7:06 AM Jesper Dangaard Brouer <brouer@xxxxxxxxxx> wrote:
>
> On Wed, 7 Oct 2020 16:46:10 -0700
> Maciej Żenczykowski <maze@xxxxxxxxxx> wrote:
>
> > > static u32 __bpf_skb_max_len(const struct sk_buff *skb)
> > > {
> > > - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_len :
> > > - SKB_MAX_ALLOC;
> > > + return IP_MAX_MTU;
> > > }
> >
> > Shouldn't we just delete this helper instead and replace call sites?
>
> It does seem wrong to pass argument skb into this function, as it is
> no-longer used...
>
> Guess I can simply replace __bpf_skb_max_len with IP_MAX_MTU.
Should that be IP6_MAX_MTU, which is larger than IP_MAX_MTU?
