Re: [PATCH bpf-next] bpf: deref map in BPF_PROG_BIND_MAP when it's already used

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Fri, Oct 2, 2020 at 5:25 PM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote:
>
> We are missing a deref for the case when we are doing BPF_PROG_BIND_MAP
> on a map that's being already held by the program.
> There is 'if (ret) bpf_map_put(map)' below which doesn't trigger
> because we don't consider this an error.
> Let's add missing bpf_map_put() for this specific condition.
>
> Fixes: ef15314aa5de ("bpf: Add BPF_PROG_BIND_MAP syscall")
> Reported-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx>

Thanks for the quick fix! Much appreciated.