On Thu, Oct 1, 2020 at 2:07 PM Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> wrote: > > On Thu, Oct 1, 2020 at 1:57 PM Hao Luo <haoluo@xxxxxxxxxx> wrote: > > > > Arnaldo, thanks for the update. In that case, I think on the kernel > > side I need to skip encoding percpu vars for this pahole release, and > > re-enable for the next pahole release. (assuming the flag for opt-out > > is in this release). Alexei, do you have any better idea? > > I'm not following. Let's get this fix landed in pahole and > release new 1.18 with it. Sorry, I misunderstood Arnaldo. I thought what he was saying was, not having this fix in an officially released version (I took this as the new 1.18) and will get 1.19 quicker. It would be ideal if we can have this in 1.18. Sorry for my bad reading. > The opt-out flag is orthogonal. I can be done in 1.19 or whenever. > With your kernel patches the kernel will reject percpu vars when pahole > is too old, because they will not be found in vmlinux btf, > so I don't see any compatibility issues. > There is no need to bump the required min version of pahole in > scripts/link-vmlinux.sh. > It can stay as v1.16. We only need clean verifier message that percpu BTF > is not found and the kernel needs to be rebuilt with pahole 1.18.
