> On Sep 30, 2020, at 7:49 AM, Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
>
> On 9/29/20 11:56 PM, Song Liu wrote:
> [...]
>> +static void bpf_fd_array_map_clear(struct bpf_map *map);
>> +
>> +static void perf_event_fd_array_map_free(struct bpf_map *map)
>> +{
>> + if (map->map_flags & BPF_F_PRESERVE_ELEMS)
>> + bpf_fd_array_map_clear(map);
>> + fd_array_map_free(map);
>> +}
>
> Not quite sure why you place that here and added the fwd declaration? If you
> place perf_event_fd_array_map_free() near perf_event_array_map_ops, then you
> also don't need the additional bpf_fd_array_map_clear declaration.
Yeah.. I misread the line number...
Fixing it in v3.
Thanks,
Song
