On Tue, Sep 29, 2020 at 5:32 AM Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > If programs in prog_tests using skeletons declare the 'skel' variable as > global but not static, that will lead to linker errors on the final link of > the prog_tests binary due to duplicate symbols. Fix a few instances of this. > > Fixes: b18c1f0aa477 ("bpf: selftest: Adapt sock_fields test to use skel and global variables") > Fixes: 9a856cae2217 ("bpf: selftest: Add test_btf_skc_cls_ingress") > Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> Thanks for the fix. Applied. I wonder why we don't see it with different gcc and clang versions. What linker do you use? And what kind of error do you see?